How to respond to code review feedback without getting defensive
code review etiquette, responding to comments, requesting re-review, resolving conversations, pushback on wrong feedback, asking clarifying questions, review as learning
Code Review Is Collaboration, Not Judgment
Your first code review will feel personal. It is not. The reviewer is evaluating the code, not you. Treating it as a learning conversation -- not a verdict -- changes how you read every comment.
How to Respond
Acknowledge first. Even if you disagree, start with understanding: Good point -- I missed that the null check needs to happen before the cast, not after.
For requests you agree with: Make the change, push, reply with a short note: Fixed in the latest commit.
For requests you disagree with: Explain your reasoning calmly and ask for clarification: I kept it this way because X -- is there a case I am missing? The maintainer may have context you do not.
What Not to Do
Never argue in a comment thread without a proposal. Never ghost a PR after receiving feedback. Never mark conversations as resolved if the reviewer has not confirmed they are happy -- that is the reviewer's job, not yours.
Requesting Re-Review
After addressing all comments, push your changes and use the GitHub Re-request review button next to the reviewer name. A short comment like: All feedback addressed -- ready for re-review, helps the maintainer know when you are ready.